Bug fix preventing deleteOneMsg from ever responding with 404 as well as adding the unit test for deleteOneMsg 404 response

This commit is contained in:
Gregory Campbell
2021-11-25 21:40:34 -05:00
parent b0d449d012
commit 1776e011f2
2 changed files with 14 additions and 2 deletions
+2 -2
View File
@@ -84,9 +84,9 @@ const deleteOneMsg = (req, res) => {
Msg.deleteOne({id:req.params.id}, (err, data) => {
//if there's nothing to delete return a message
if( data.deletedCount == 0) return res.status(400).json({message: "Message can't be deleted, it doesn't exist."});
if (err) return res.status(404).json(`Something went wrong, please try again. ${err}`);
//else if there's an error, return the err message
else if (err) return res.status(404).json(`Something went wrong, please try again. ${err}`);
else if( data.deletedCount == 0) return res.status(400).json({message: "Message can't be deleted, it doesn't exist."});
//else, return the success message
else return res.status(200).json({message: "Message deleted."});
});
+12
View File
@@ -159,6 +159,18 @@ describe('DELETE /msg/:id', function () {
done();
});
});
it('respond with 404 error', function (done) {
request(app)
.delete('/msg/idisnonexisting')
.set('Accept', 'application/json')
.expect(404) //expecting HTTP status code
.expect('Content-Type', /json/) // expecting content value
.end((err) => {
if (err) return done(err);
done();
});
});
});
describe('DELETE /msg', function () {